From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbbFDGDC (ORCPT ); Thu, 4 Jun 2015 02:03:02 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36715 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbbFDGCz (ORCPT ); Thu, 4 Jun 2015 02:02:55 -0400 Date: Thu, 4 Jun 2015 11:32:47 +0530 From: Sudip Mukherjee To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c Message-ID: <20150604060247.GD6376@sudip-PC> References: <1433361433-24976-1-git-send-email-jsimmons@infradead.org> <1433361433-24976-7-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433361433-24976-7-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 03:57:12PM -0400, James Simmons wrote: > Handle all the style issues reported by checkpatch.pl. > Remove general white spaces, spaces in function calls, > etc. > > Signed-off-by: James Simmons > --- > @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) > if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { > toobig = 1; > nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); > - CWARN("Too many interfaces: only enumerating first %d\n", > - nalloc); > + CWARN("Too many interfaces: only enumerating " > + "first %d\n", nalloc); oops. Joe told you not to break the user visible strings. The CodingStyle says: "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." regards sudip