From: Nicholas Mc Guire <der.herr@hofr.at>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Joe Perches <joe@perches.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
Michal Marek <mmarek@suse.cz>,
Masahiro Yamada <yamada.m@jp.panasonic.com>,
Sam Ravnborg <sam@ravnborg.org>, "H. Peter Alvin" <hpa@zytor.com>,
John Stultz <john.stultz@linaro.org>,
Andrew Hunter <ahh@google.com>, Paul Turner <pjt@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] time: allow gcc to fold constants when possible
Date: Thu, 4 Jun 2015 09:27:25 +0200 [thread overview]
Message-ID: <20150604072725.GC30121@opentech.at> (raw)
In-Reply-To: <alpine.DEB.2.11.1506022319570.20347@nanos>
On Tue, 02 Jun 2015, Thomas Gleixner wrote:
> On Thu, 28 May 2015, Joe Perches wrote:
> > On Thu, 2015-05-28 at 19:09 +0200, Nicholas Mc Guire wrote:
> > > To allow constant folding in usecs_to_jiffies() conditionally calls
> > > the HZ dependent _usecs_to_jiffies() helpers or, when gcc can not
> > > figure out constant folding, __usecs_to_jiffies, which is the renamed
> > > original usecs_to_jiffies() function.
> >
> > Hi Nicholas.
> >
> > Thanks for following through with this.
> >
> > The subject might be nicer if it referenced usecs_to_jiffies
> > instead of being a bit generic.
> >
> > Maybe something like:
> >
> > time: allow gcc to fold usecs_to_jiffies(constant)
>
> And for correctness sake the first letter after the colon, i.e. the
> one starting the sentence wants to be uppercase.
>
added to my list of checks - sorry for being sloppy on that
> I'm going to fix that up all together when applying the lot. No need
> for resend.
>
thanks !
hofrat
next prev parent reply other threads:[~2015-06-04 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 17:09 [PATCH 1/2] time: refactor usecs_to_jiffies Nicholas Mc Guire
2015-05-28 17:09 ` [PATCH 2/2] time: allow gcc to fold constants when possible Nicholas Mc Guire
2015-05-28 18:02 ` Joe Perches
2015-06-02 21:23 ` Thomas Gleixner
2015-06-02 21:31 ` John Stultz
2015-06-02 21:41 ` Joe Perches
2015-06-04 7:27 ` Nicholas Mc Guire [this message]
2015-06-12 9:30 ` [tip:timers/core] time: Allow gcc to fold usecs_to_jiffies( constant) tip-bot for Nicholas Mc Guire
2015-06-12 9:30 ` [tip:timers/core] time: Refactor usecs_to_jiffies tip-bot for Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604072725.GC30121@opentech.at \
--to=der.herr@hofr.at \
--cc=ahh@google.com \
--cc=hofrat@osadl.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pjt@google.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox