From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbbFDH1f (ORCPT ); Thu, 4 Jun 2015 03:27:35 -0400 Received: from hofr.at ([212.69.189.236]:56476 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbFDH12 (ORCPT ); Thu, 4 Jun 2015 03:27:28 -0400 Date: Thu, 4 Jun 2015 09:27:25 +0200 From: Nicholas Mc Guire To: Thomas Gleixner Cc: Joe Perches , Nicholas Mc Guire , Michal Marek , Masahiro Yamada , Sam Ravnborg , "H. Peter Alvin" , John Stultz , Andrew Hunter , Paul Turner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] time: allow gcc to fold constants when possible Message-ID: <20150604072725.GC30121@opentech.at> References: <1432832996-12129-1-git-send-email-hofrat@osadl.org> <1432832996-12129-2-git-send-email-hofrat@osadl.org> <1432836156.2846.237.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Jun 2015, Thomas Gleixner wrote: > On Thu, 28 May 2015, Joe Perches wrote: > > On Thu, 2015-05-28 at 19:09 +0200, Nicholas Mc Guire wrote: > > > To allow constant folding in usecs_to_jiffies() conditionally calls > > > the HZ dependent _usecs_to_jiffies() helpers or, when gcc can not > > > figure out constant folding, __usecs_to_jiffies, which is the renamed > > > original usecs_to_jiffies() function. > > > > Hi Nicholas. > > > > Thanks for following through with this. > > > > The subject might be nicer if it referenced usecs_to_jiffies > > instead of being a bit generic. > > > > Maybe something like: > > > > time: allow gcc to fold usecs_to_jiffies(constant) > > And for correctness sake the first letter after the colon, i.e. the > one starting the sentence wants to be uppercase. > added to my list of checks - sorry for being sloppy on that > I'm going to fix that up all together when applying the lot. No need > for resend. > thanks ! hofrat