Re: [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c

Sudip Mukherjee
2015-06-04T06:03:02Z

On Wed, Jun 03, 2015 at 03:57:12PM -0400, James Simmons wrote:
> Handle all the style issues reported by checkpatch.pl.
> Remove general white spaces, spaces in function calls,
> etc.
>
> Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
<snip>
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
> toobig = 1;
> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> - CWARN("Too many interfaces: only enumerating first %d\n",
> - nalloc);
> + CWARN("Too many interfaces: only enumerating "
> + "first %d\n", nalloc);
oops. Joe told you not to break the user visible strings.

The CodingStyle says: "However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them."

regards
sudip