From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbbFDHmG (ORCPT ); Thu, 4 Jun 2015 03:42:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42783 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbbFDHmD (ORCPT ); Thu, 4 Jun 2015 03:42:03 -0400 Date: Thu, 4 Jun 2015 10:41:07 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: James Simmons , devel@driverdev.osuosl.org, Andreas Dilger , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , lustre-devel@lists.lustre.org Subject: Re: [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix Message-ID: <20150604074107.GB28762@mwanda> References: <1433361433-24976-1-git-send-email-jsimmons@infradead.org> <1433361433-24976-5-git-send-email-jsimmons@infradead.org> <20150604055710.GC6376@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150604055710.GC6376@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2015 at 11:27:10AM +0530, Sudip Mukherjee wrote: > On Wed, Jun 03, 2015 at 03:57:10PM -0400, James Simmons wrote: > > With all the TCPIP handling done in the lnet layer we should > > rename all the functions with the prefix lnet_*. One other > > change done was changing the remove argument of lnet_sock_getaddr > > from a int to a bool. > thats two different change. > and apart from this: > 1) the function declarations were renamed and moved from > lustre/include/linux/libcfs/libcfs.h to drivers/staging/lustre/include/linux/lnet/lib-lnet.h > > 2) some functions you have changed the coding style. like: > - rc = libcfs_sock_getaddr(conn->ksnc_sock, 0, > - &conn->ksnc_myipaddr, NULL); > + rc = lnet_sock_getaddr(conn->ksnc_sock, 0, &conn->ksnc_myipaddr, NULL); > Those are tiny related changes. They're fine. When you rename functions you normally have to change the indenting as well. regards, dan carpenter