From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix out of bound access
Date: Thu, 4 Jun 2015 18:17:18 +0530 [thread overview]
Message-ID: <20150604124332.GA20510@sudip-PC> (raw)
In-Reply-To: <20150604123631.GE28762@mwanda>
On Thu, Jun 04, 2015 at 03:36:31PM +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote:
> > size of str is 16, but in snprintf the size was mentioned as 128.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
<snip>
> Good eye. How did you find this?
:) not me. cppcheck.
>
> The good news is buf[j] is <= 0xFFFF so it won't actually overflow. Who
> knows why it is zero padded 2 spaces... But use sizeof(str) instead of
> 16.
but my v2 will remove the use of msg and str.
regards
sudip
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2015-06-04 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 11:42 [PATCH] staging: fbtft: fix out of bound access Sudip Mukherjee
2015-06-04 12:12 ` Joe Perches
2015-06-04 12:21 ` Sudip Mukherjee
2015-06-04 12:36 ` Dan Carpenter
2015-06-04 12:47 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604124332.GA20510@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox