From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753676AbbFDMrb (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Jun 2015 08:47:31 -0400
Received: from mail-pd0-f177.google.com ([209.85.192.177]:35788 "EHLO
	mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753618AbbFDMra (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Jun 2015 08:47:30 -0400
Date: Thu, 4 Jun 2015 18:17:18 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix out of bound access
Message-ID: <20150604124332.GA20510@sudip-PC>
References: <1433418121-9434-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150604123631.GE28762@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150604123631.GE28762@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 04, 2015 at 03:36:31PM +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote:
> > size of str is 16, but in snprintf the size was mentioned as 128.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
<snip>
> Good eye.  How did you find this?
:) not me. cppcheck. 
> 
> The good news is buf[j] is <= 0xFFFF so it won't actually overflow.  Who
> knows why it is zero padded 2 spaces...  But use sizeof(str) instead of
> 16.
but my v2 will remove the use of msg and str.

regards
sudip
> 
> regards,
> dan carpenter
>