Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

Sudip Mukherjee
2015-06-04T06:07:02Z

On Thu, Jun 04, 2015 at 07:50:07AM +0200, Mateusz Kulikowski wrote:
> On 04.06.2015 07:18, Sudip Mukherjee wrote:
> > On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
> >> On 03.06.2015 09:26, Sudip Mukherjee wrote:
> >>> On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
> >>
> >> No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
> >> Thanks for finding it - I'll fix that in v2.
> >>
> >> Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?
> >
> > at a first glance looked ok to me. I hope you have checked it on the
> > hardware as well. but maybe Dan can find something.
> > better send v2.
>
> Of course I have checked it, although - as I wrote in past - this driver has not very good performance.
is there any other driver which has better performance on this hardware
than this driver? and how are you measuring the performance?

regards
sudip
>
> I'll post v2 soon.
>
> Regards,
> Mateusz