Re: [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch]

Dan Carpenter
2015-06-04T13:52:31Z

On Tue, Jun 02, 2015 at 10:48:10PM +0200, Mateusz Kulikowski wrote:
> - Remove unused fields in dig_t structures. Some of them were only
> initialized and never accessed.
> - Remove unused enums/macros/defines in rtl_dm.h
> - Remove duplicated function declarations
> - Remove unused dm_change_dynamic_initgain_thresh() function
> - Remove unused dm_shadow_init() function

Could you delete dm_shadow[] in a follow on patch.

How I review these sorts of patches is that:
1) Ignore deleted variables. If those are used then it will cause a
compile problem so I don't worry about it.

2) Verify that when we delete initialization, then we also delete the
variable. In this case we deleted the initialization of dm_shadow[]
but not the variable itself, so I wondered if we were using
unitialized data. It turns out that it was just an oversight.

Reviewing these means a lot of searching, for each variable. Next time
if the patch were split up more it would make it a bit easier.

regards,
dan carpenter