Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

Mateusz Kulikowski
2015-06-03T18:21:16Z

On 03.06.2015 09:26, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
>> dig_t::dbg_mode is initialized to one value and checked only once in code.
>> This patch throws it away, and deletes always-true condition.
>>
>> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
>> ---
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 5 +----
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 24 ------------------------
>> 2 files changed, 1 insertion(+), 28 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
>> index d869629..95a7c8e 100644
>> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
>> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> <snip>
>> @@ -1949,7 +1947,6 @@ static void dm_init_rxpath_selection(struct net_device *dev)
>> DM_RxPathSelTable.cck_method = CCK_Rx_Version_2;
>> else
>> DM_RxPathSelTable.cck_method = CCK_Rx_Version_1;
>> - DM_RxPathSelTable.DbgMode = DM_DBG_OFF;
> so now DM_RxPathSelTable.DbgMode is not initialized, but at line 1992 we have
>
> if (!DM_RxPathSelTable.DbgMode)
> DM_RxPathSelTable.rf_rssi[i] = priv->stats.rx_rssi_percentage[i];
>
> am i missing something here?

No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
Thanks for finding it - I'll fix that in v2.

Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?

Regards,
Mateusz