From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Devendra Naga <devendra.aaru@gmail.com>,
Bryan Thompson <bryan.thompson@unisys.com>,
Michel von Czettritz <michel.von.czettritz@gmail.com>,
sparmaintainer@unisys.com, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: unisys: drop format string in kthread_run
Date: Fri, 5 Jun 2015 12:05:58 +0530 [thread overview]
Message-ID: <20150605063558.GE16319@sudip-PC> (raw)
In-Reply-To: <20150604183701.GA19803@www.outflux.net>
On Thu, Jun 04, 2015 at 11:37:01AM -0700, Kees Cook wrote:
> Calling kthread_run with a single name parameter causes it to be handled
> as a format string. Since the uisthread interface lacks format parameters,
> use "%s" to avoid any potential accidents from callers passing in dynamic
> string content.
uislib folder has already been deleted in staging-testing tree.
regards
sudip
prev parent reply other threads:[~2015-06-05 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 18:37 [PATCH] staging: unisys: drop format string in kthread_run Kees Cook
2015-06-05 6:35 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605063558.GE16319@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=benjamin.romer@unisys.com \
--cc=bryan.thompson@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.von.czettritz@gmail.com \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox