From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbbFEGgJ (ORCPT ); Fri, 5 Jun 2015 02:36:09 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34378 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbbFEGgG (ORCPT ); Fri, 5 Jun 2015 02:36:06 -0400 Date: Fri, 5 Jun 2015 12:05:58 +0530 From: Sudip Mukherjee To: Kees Cook Cc: linux-kernel@vger.kernel.org, Benjamin Romer , David Kershner , Greg Kroah-Hartman , Devendra Naga , Bryan Thompson , Michel von Czettritz , sparmaintainer@unisys.com, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: unisys: drop format string in kthread_run Message-ID: <20150605063558.GE16319@sudip-PC> References: <20150604183701.GA19803@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150604183701.GA19803@www.outflux.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2015 at 11:37:01AM -0700, Kees Cook wrote: > Calling kthread_run with a single name parameter causes it to be handled > as a format string. Since the uisthread interface lacks format parameters, > use "%s" to avoid any potential accidents from callers passing in dynamic > string content. uislib folder has already been deleted in staging-testing tree. regards sudip