public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/
Date: Fri, 5 Jun 2015 09:37:23 +0200	[thread overview]
Message-ID: <20150605073723.GA21312@gmail.com> (raw)
In-Reply-To: <556F411A.1050409@zytor.com>


* H. Peter Anvin <hpa@zytor.com> wrote:

> I really dislike deep hierarchies, as I said, because my experience has been 
> that they are more confusing than they are helpful, especially over time.  The 
> arch-example of badness is of course arch/x86/kernel, which is a total 
> catch-all, but

Well, directory hierarchy can certainly be overdone, but in general the Linux 
kernel has the exact opposite problem: too shallow directory organization due to 
two decades of organic growth.

We've been actively working over the last two years to improve the source code 
hierarchy gradually: kernel/rcu/, kernel/locking/, kernel/events/, kernel/sched/ 
and kernel/time/ are all examples of that process. It worked out pretty well IMHO.

This series actively depopulates various catch-all places such as arch/x86/kernel/ 
and arch/x86/lib/ and moves related code closer to each other.

The purpose of arch/x86/entry/ is:

 - implementation of the high level runtime interfaces to enter/exit (call) the 
   Linux kernel, both for hardware and for software defined ABIs.

Each of the files moved directly relate to these interfaces. It's not limited to 
kernel mode entries alone.

We could rename it to arch/x86/abi/, although that would be somewhat confusing I 
suspect because it's too generic a name?

Anyway, I pushed this out as it's a step forward and to not hold up ongoing asm 
work - we'll see how it works out in practice!

Thanks,

	Ingo

      reply	other threads:[~2015-06-05  7:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:59 [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 1/7] x86/asm/entry: Move entry_64.S and entry_32.S to arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 2/7] x86/asm/entry: Move the compat syscall entry code " Ingo Molnar
2015-06-03 17:04   ` Andy Lutomirski
2015-06-03 17:11     ` Ingo Molnar
2015-06-03 16:59 ` [PATCH 3/7] x86/asm/entry, x86/vdso: Move the vDSO code to arch/x86/entry/vdso/ Ingo Molnar
2015-06-03 17:05   ` Andy Lutomirski
2015-06-03 16:59 ` [PATCH 4/7] x86/asm/entry: Move the 'thunk' functions to arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 5/7] x86/asm/entry: Move arch/x86/include/asm/calling.h " Ingo Molnar
2015-06-03 16:59 ` [PATCH 6/7] x86/asm/entry: Move the arch/x86/syscalls/ definitions to arch/x86/entry/syscalls/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 7/7] x86/asm/entry: Move the vsyscall code to arch/x86/entry/vsyscall/ Ingo Molnar
2015-06-03 17:03 ` [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/ H. Peter Anvin
2015-06-03 17:11   ` Ingo Molnar
2015-06-03 17:13     ` Andy Lutomirski
2015-06-03 17:16       ` Ingo Molnar
2015-06-03 17:21         ` Ingo Molnar
2015-06-03 17:23           ` Andy Lutomirski
2015-06-03 17:29             ` Ingo Molnar
2015-06-03 17:22         ` Andy Lutomirski
2015-06-03 18:04           ` H. Peter Anvin
2015-06-03 18:18             ` H. Peter Anvin
2015-06-03 17:07 ` Andy Lutomirski
2015-06-03 17:08   ` Andy Lutomirski
2015-06-03 17:13     ` Ingo Molnar
2015-06-03 18:02       ` H. Peter Anvin
2015-06-05  7:37         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150605073723.GA21312@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox