Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI

[Matt Fleming <matt@codeblueprint.co.uk>]

(Cc'ing David)

On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote:
> As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721
> When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and
> login on console.
> 
> Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so
> skip it.
> 
> This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9
> with kernel 4.0.4
> 
> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
> Tested-by: Kunlun Lao <kunlun.lao@oracle.com>
> ---
>  arch/x86/kernel/sysfb_simplefb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c
> index 764a29f..f833502 100644
> --- a/arch/x86/kernel/sysfb_simplefb.c
> +++ b/arch/x86/kernel/sysfb_simplefb.c
> @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si,
>  	unsigned int i;
>  
>  	type = si->orig_video_isVGA;
> -	if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI)
> +	if (type != VIDEO_TYPE_VLFB)
>  		return false;
>  
>  	for (i = 0; i < ARRAY_SIZE(formats); ++i) {

This patch makes sense to me, but I'd really like David to fill us in on
the rationale for including VIDEO_TYPE_EFI in the simplefb list in first
place, and whether he's aware of any platforms that require simplefb for
UEFI.

David?

-- 
Matt Fleming, Intel Open Source Technology Center