From: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: "'Kay Sievers'" <kay@vrfy.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] driver: core: add uid gid to class devnode
Date: Fri, 5 Jun 2015 19:19:16 +0900 [thread overview]
Message-ID: <20150605101916.GA3802@kroah.com> (raw)
In-Reply-To: <00eb01d09f77$d4f2c930$7ed85b90$@samsung.com>
On Fri, Jun 05, 2015 at 07:10:21PM +0900, Namjae Jeon wrote:
> Add support for setting uid gid to devtmpfs device nodes.
> In this manner, drivers can specify desired uid gid in their
> class->devnode method.
>
> This is extension of existing method of setting uid gid by drivers
> using device_type->devnode method:
> 3c2670e6515cf584810f417db9b00992c8b2d75a
> "driver core: add uid and gid to devtmpfs"
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
You add new parameters to these functions, yet never use them. Sorry, I
need an actual user before I can accept api changes like this.
Same for the other 2 patches in this series, I can't accept api changes
without a real user of them, otherwise I'll just have to rip them out
again to simplify the code.
sorry,
greg k-h
next prev parent reply other threads:[~2015-06-05 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 10:10 [PATCH 1/3] driver: core: add uid gid to class devnode Namjae Jeon
2015-06-05 10:19 ` 'Greg Kroah-Hartman' [this message]
2015-06-05 11:15 ` Namjae Jeon
2015-06-05 11:49 ` 'Greg Kroah-Hartman'
2015-06-05 10:19 ` 'Greg Kroah-Hartman'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605101916.GA3802@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox