From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbbFEKhe (ORCPT ); Fri, 5 Jun 2015 06:37:34 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53745 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbFEKhd (ORCPT ); Fri, 5 Jun 2015 06:37:33 -0400 Date: Fri, 5 Jun 2015 12:37:27 +0200 From: Pavel Machek To: Joe Perches Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] power: user: Standardize "Syncing filesystems ..." message Message-ID: <20150605103727.GA6054@amd> References: <06fdc51c7d2ab639729107a137b947704fd7d161.1433442778.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06fdc51c7d2ab639729107a137b947704fd7d161.1433442778.git.joe@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2015-06-04 11:36:48, Joe Perches wrote: > Instead of a two individual printks that would generally be > emitted on a single line, emit 2 lines to make the start > and end of the synchronization more easily timeable. > > Signed-off-by: Joe Perches > --- > kernel/power/user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/power/user.c b/kernel/power/user.c > index 526e891..e22f6ad 100644 > --- a/kernel/power/user.c > +++ b/kernel/power/user.c > @@ -221,9 +221,9 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, > if (data->frozen) > break; > > - printk("Syncing filesystems ... "); > + printk("Syncing filesystems ...\n"); > sys_sync(); > - printk("done.\n"); > + printk("Syncing filesystems: done\n"); You converted " ..." -> "..." elsewhere, so why not here? Is splitting message to two lines a good idea? Is it time to introduce helper function that does the sync with the printing? I must say that I'm to a great fan on adding more lines to hibernation output. Eats too much vertical space on screen, etc. Do you see real problems there or are you just trying to "improve" this? I'm pretty sure sync timing can be easily obtained from other messages around this one... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html