Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

Javier Martinez Canillas
2015-06-05T10:40:45Z

Hello Lee,

On 06/05/2015 12:38 PM, Lee Jones wrote:

[...]

>>
>> - err = mfd_add_devices(dev, 0, cros_devs,
>> - ARRAY_SIZE(cros_devs),
>> + err = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_cell, 1,
>> NULL, ec_dev->irq, NULL);
>> if (err) {
>> - dev_err(dev, "failed to add mfd devices\n");
>> + dev_err(dev, "add Embedded Controller mfd device failed %d\n",
>
> Nit: As you're likely to resubmit anyway, when do do so, can you turn
> this into an English sentence?
>
> "failed to register Embedded Controller's sub-devices"
>
> ... or something.
>

Ok, I will.

Best regards,
Javier