Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

Javier Martinez Canillas
2015-06-05T10:20:13Z

Hello Lee,

On 06/05/2015 12:17 PM, Lee Jones wrote:
> On Thu, 04 Jun 2015, Javier Martinez Canillas wrote:
>
>> From: Gwendal Grignou <gwendal@chromium.org>
>>
>> Chromebooks can have more than one Embedded Controller so the
>> cros_ec device id has to be incremented for each EC registered.
>>
>> Add a new structure to represent multiple EC as different char
>> devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to
>> cros_ec_device and allows sysfs inferface for cros_pd.
>>
>> Also reduce number of allocated objects, make chromeos sysfs
>> class object a static and add refcounting to prevent object
>> deletion while command is in progress.
>>
>> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
>> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Tested-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>
>> Changes since v5:
>> - Don't allow to change the device name from DT. Suggested by Lee Jones.
>> - Expand error messages in case of mfd_add_devices() failure.
>> Suggested by Lee Jones.
>>
>> Changes since v4:
>> - Use cros-ec-name DT property instead of devname. Suggested by Lee Jones.
>> - Pass PLATFORM_DEVID_AUTO directly to mfd_add_devices().
>> Suggested by Lee Jones.
>> - Add Heiko Stuebner tested-by tag.
>> - Fix get_version by passing the cmd_offset to EC_CMD_GET_VERSION.
>>
>> Changes since v3:
>> - Add defines for the EC and PD index constants.
>> - Remove cros_ec_dev_register() and declare the mfd_cells as static structs.
>> Suggested by Lee Jones.
>> - Add a new line before the return statement in cros_ec_dev_register().
>> Suggested by Lee Jones.
>>
>> Changes since v2: None
>>
>> Changes since v1:
>> - Squash patch that adds support to represent EC's as different
>> char devices (e.g: /dev/cros_ec, /dev/cros_pd):
>> https://chromium-review.googlesource.com/#/c/217297/
>> Suggested by Gwendal Grignou
>> - Use cros_ec instead of cros-ec in the subject line to be consistent.
>> Suggested by Gwendal Grignou
>> ---
>> drivers/input/keyboard/cros_ec_keyb.c | 2 +-
>> drivers/mfd/cros_ec.c | 52 ++++++++++--
>> drivers/mfd/cros_ec_i2c.c | 1 -
>> drivers/mfd/cros_ec_spi.c | 1 -
>> drivers/platform/chrome/cros_ec_dev.c | 130 ++++++++++++++++++++---------
>> drivers/platform/chrome/cros_ec_dev.h | 7 --
>> drivers/platform/chrome/cros_ec_lightbar.c | 75 +++++++++--------
>> drivers/platform/chrome/cros_ec_lpc.c | 1 -
>> drivers/platform/chrome/cros_ec_sysfs.c | 48 +++++------
>> include/linux/mfd/cros_ec.h | 44 ++++++++--
>> 10 files changed, 234 insertions(+), 127 deletions(-)
>
> For my own reference:
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Let me know when you have all the appropriate Acks and I'll apply the
> set.
>

I will, thanks a lot for your help and all the feedback.

Best regards,
Javier