[PATCH 3/3] driver: core: add security labels to misc class devnode

[PATCH 3/3] driver: core: add security labels to misc class devnode

[Namjae Jeon]

Add support for setting security labels on devtmpfs nodes created
by misc class drivers using misc_register.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
---
 drivers/char/misc.c        | 5 +++++
 include/linux/miscdevice.h | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 63fb739..42fc006 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -274,6 +274,11 @@ static char *misc_devnode(struct device *dev, umode_t *mode,
 
 	if (mode && c->mode)
 		*mode = c->mode;
+	if (xattr && xattr->value && c->xattr_value) {
+		xattr->name = c->xattr_name;
+		strcpy(xattr->value, c->xattr_value);
+		xattr->value_len = strlen(xattr->value);
+	}
 	if (c->nodename)
 		return kstrdup(c->nodename, GFP_KERNEL);
 	return NULL;
diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index 819077c..bcc3d8e 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -64,6 +64,8 @@ struct miscdevice  {
 	const struct attribute_group **groups;
 	const char *nodename;
 	umode_t mode;
+	const char *xattr_name;
+	const char *xattr_value;
 };
 
 extern int misc_register(struct miscdevice *misc);
-- 
1.8.5.5

Re: [PATCH 3/3] driver: core: add security labels to misc class devnode

['Greg Kroah-Hartman']

On Fri, Jun 05, 2015 at 07:10:24PM +0900, Namjae Jeon wrote:
> Add support for setting security labels on devtmpfs nodes created
> by misc class drivers using misc_register.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>

Again, which misc driver wants to do this?

thanks,

greg k-h

RE: [PATCH 3/3] driver: core: add security labels to misc class devnode

[Namjae Jeon]

> On Fri, Jun 05, 2015 at 07:10:24PM +0900, Namjae Jeon wrote:
> > Add support for setting security labels on devtmpfs nodes created
> > by misc class drivers using misc_register.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
> 
> Again, which misc driver wants to do this?
yes, misc driver in our system(tizen) want to use this feature.
I think this will be useful for other systems also which do not have
udev like user space helpers
> 
> thanks,
> 
> greg k-h

Re: [PATCH 3/3] driver: core: add security labels to misc class devnode

['Greg Kroah-Hartman']

On Fri, Jun 05, 2015 at 08:16:00PM +0900, Namjae Jeon wrote:
> > On Fri, Jun 05, 2015 at 07:10:24PM +0900, Namjae Jeon wrote:
> > > Add support for setting security labels on devtmpfs nodes created
> > > by misc class drivers using misc_register.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
> > 
> > Again, which misc driver wants to do this?
> yes, misc driver in our system(tizen) want to use this feature.
> I think this will be useful for other systems also which do not have
> udev like user space helpers

I don't see that driver merged so I can't accept this, sorry.

greg k-h