From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030230AbbFESRb (ORCPT ); Fri, 5 Jun 2015 14:17:31 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:35547 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbbFESR1 (ORCPT ); Fri, 5 Jun 2015 14:17:27 -0400 Date: Fri, 5 Jun 2015 11:16:45 -0700 From: Sukadev Bhattiprolu To: Andi Kleen Cc: Jiri Olsa , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Message-ID: <20150605181645.GA25927@us.ibm.com> References: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433485647-9314-16-git-send-email-sukadev@linux.vnet.ibm.com> <20150605102138.GB29934@krava.redhat.com> <20150605161926.GU1187@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150605161926.GU1187@tassilo.jf.intel.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060518-0017-0000-0000-00000B6ADF4A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen [ak@linux.intel.com] wrote: | On Fri, Jun 05, 2015 at 12:21:38PM +0200, Jiri Olsa wrote: | > On Thu, Jun 04, 2015 at 11:27:23PM -0700, Sukadev Bhattiprolu wrote: | > | > SNIP | > | > > --- | > > tools/perf/builtin-list.c | 11 ++++++++--- | > > 1 file changed, 8 insertions(+), 3 deletions(-) | > > | > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c | > > index 3f058f7..d0f7a18 100644 | > > --- a/tools/perf/builtin-list.c | > > +++ b/tools/perf/builtin-list.c | > > @@ -22,10 +22,13 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused) | > > { | > > int i; | > > bool raw_dump = false; | > > + bool long_desc_flag = false; | > > struct option list_options[] = { | > > OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"), | > > OPT_BOOLEAN('d', "desc", &desc_flag, | > > "Print extra event descriptions. --no-desc to not print."), | > > + OPT_BOOLEAN('d', "long-desc", &long_desc_flag, | > > + "Print longer event descriptions."), | > | > hum, it should be 'v' , right? Good catch. Fixed. | | Yes that's right. | | Also BTW need to add the new option to the usage line a few lines below. How about we do this for consistency with 'perf stat'(and shows the long options exactly once with 'perf list -h')? diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index d0f7a18..f800927 100644 --- a/tools/perf/builtin-list.c +++ b/tools/perf/builtin-list.c @@ -27,12 +27,12 @@ int cmd_list(int argc, const char **argv, const char *prefi OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"), OPT_BOOLEAN('d', "desc", &desc_flag, "Print extra event descriptions. --no-desc to not p - OPT_BOOLEAN('d', "long-desc", &long_desc_flag, + OPT_BOOLEAN('v', "long-desc", &long_desc_flag, "Print longer event descriptions."), OPT_END() }; const char * const list_usage[] = { - "perf list [--no-desc] [hw|sw|cache|tracepoint|pmu|event_glob]" + "perf list [] [hw|sw|cache|tracepoint|pmu|event_glob]" NULL }; | | -Andi | | -- | ak@linux.intel.com -- Speaking for myself only