From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbbFFHIY (ORCPT ); Sat, 6 Jun 2015 03:08:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbbFFHIU (ORCPT ); Sat, 6 Jun 2015 03:08:20 -0400 Date: Sat, 6 Jun 2015 09:08:12 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: Andi Kleen , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Message-ID: <20150606070812.GA3412@krava.redhat.com> References: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433485647-9314-16-git-send-email-sukadev@linux.vnet.ibm.com> <20150605102138.GB29934@krava.redhat.com> <20150605161926.GU1187@tassilo.jf.intel.com> <20150605181645.GA25927@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150605181645.GA25927@us.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 05, 2015 at 11:16:45AM -0700, Sukadev Bhattiprolu wrote: SNIP > | > hum, it should be 'v' , right? > > Good catch. Fixed. > | > | Yes that's right. > | > | Also BTW need to add the new option to the usage line a few lines below. > > How about we do this for consistency with 'perf stat'(and shows the > long options exactly once with 'perf list -h')? > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > index d0f7a18..f800927 100644 > --- a/tools/perf/builtin-list.c > +++ b/tools/perf/builtin-list.c > @@ -27,12 +27,12 @@ int cmd_list(int argc, const char **argv, const char *prefi > OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"), > OPT_BOOLEAN('d', "desc", &desc_flag, > "Print extra event descriptions. --no-desc to not p > - OPT_BOOLEAN('d', "long-desc", &long_desc_flag, > + OPT_BOOLEAN('v', "long-desc", &long_desc_flag, > "Print longer event descriptions."), > OPT_END() > }; > const char * const list_usage[] = { > - "perf list [--no-desc] [hw|sw|cache|tracepoint|pmu|event_glob]" > + "perf list [] [hw|sw|cache|tracepoint|pmu|event_glob]" > NULL sounds good to me, and plus the doc update ;-) thanks, jirka