Re: [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors

Borislav Petkov
2015-06-06T07:51:03Z

On Fri, Jun 05, 2015 at 06:07:34PM -0500, Aravind Gopalakrishnan wrote:
> Even though !CONFIG_SMP and MCE injection are practically mutually
> exclusive, it's better to include irq_vectors.h just in case
> randconfig builders out there don't set CONFIG_SMP.
>
> When that happens, DEFERRED_ERROR_VECTOR and THRESHOLD_APIC_VECTOR
> macro definitions go out of scope and kernel build will fail.

Good!

> Tested the .config that broke the build against latest tip with
> changes in for-next branch of bp.git and it builds fine now.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: kbuild-all@01.org
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> ---
> drivers/edac/mce_amd_inj.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 3f7217f..3e1b53f 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -18,6 +18,7 @@
> #include <linux/string.h>
> #include <linux/uaccess.h>
> #include <asm/mce.h>
> +#include <asm/irq_vectors.h>
>
> #include "mce_amd.h"

Applied, thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--