From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aparna Karuthodi <kdasaparna@gmail.com>
Cc: gregkh@linuxfoundation.org, lidza.louina@gmail.com,
devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@vger.kernel.org,
Date: Sat, 6 Jun 2015 17:35:08 +0300 [thread overview]
Message-ID: <20150606143508.GR28762@mwanda> (raw)
In-Reply-To: <20150606090251.GB8087@gmail.com>
Send the patch to yourself. Apply it with git am. Review the git log
and then send it to the list.
But actually this change is not correct at all. The prefered style in
staging is that multi-line indent blocks get curly braces for
readability even when they are not required by the compiler. The patch
introduces other coding style violations. Did you run checkpatch.pl
over it?
regards,
dan carpenter
prev parent reply other threads:[~2015-06-06 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150606085628.GA8087@gmail.com>
2015-06-06 9:02 ` [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@vger.kernel.org, Aparna Karuthodi
2015-06-06 14:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150606143508.GR28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kdasaparna@gmail.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox