From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbbFFOf0 (ORCPT ); Sat, 6 Jun 2015 10:35:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28690 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbbFFOfU (ORCPT ); Sat, 6 Jun 2015 10:35:20 -0400 Date: Sat, 6 Jun 2015 17:35:08 +0300 From: Dan Carpenter To: Aparna Karuthodi Cc: gregkh@linuxfoundation.org, lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@vger.kernel.org, Message-ID: <20150606143508.GR28762@mwanda> References: <20150606085628.GA8087@gmail.com> <20150606090251.GB8087@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150606090251.GB8087@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Send the patch to yourself. Apply it with git am. Review the git log and then send it to the list. But actually this change is not correct at all. The prefered style in staging is that multi-line indent blocks get curly braces for readability even when they are not required by the compiler. The patch introduces other coding style violations. Did you run checkpatch.pl over it? regards, dan carpenter