From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbbFGWRt (ORCPT ); Sun, 7 Jun 2015 18:17:49 -0400 Received: from mail.windriver.com ([147.11.1.11]:46081 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbbFGWRn (ORCPT ); Sun, 7 Jun 2015 18:17:43 -0400 Date: Sun, 7 Jun 2015 18:17:28 -0400 From: Paul Gortmaker To: Guenter Roeck CC: James Hogan , , , Greg Kroah-Hartman , Jiri Slaby Subject: Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h' Message-ID: <20150607221727.GA7125@windriver.com> References: <20150605204055.GA981@roeck-us.net> <20150605213900.GA30510@jhogan-linux.le.imgtec.org> <55724131.9040900@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55724131.9040900@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h'] On 05/06/2015 (Fri 17:39) Guenter Roeck wrote: > On 06/05/2015 02:39 PM, James Hogan wrote: > [ ... ] > > > > From e12856c559d7dff2ad4f6497996610e12e7c7e2d Mon Sep 17 00:00:00 2001 > >From: James Hogan > >Date: Fri, 5 Jun 2015 22:17:18 +0100 > >Subject: [PATCH] tty/metag_da: Avoid module_init/module_exit > >MIME-Version: 1.0 > >Content-Type: text/plain; charset=UTF-8 > >Content-Transfer-Encoding: 8bit > > > >The metag_da TTY driver can't get built as a module at the moment, but > >it still uses module_init() and module_exit(). Those macros are moving > >to module.h which isn't included by metag_da.c, which will result in the > >following build warnings (remarkably no build errors) and an apparent > >failure to boot as the TTY driver won't be loaded. > > > >drivers/tty/metag_da.c:660: warning: data definition has no type or storage class > >drivers/tty/metag_da.c:660: warning: type defaults to ‘int’ in declaration of ‘module_init’ > >drivers/tty/metag_da.c:660: warning: parameter names (without types) in function declaration > >drivers/tty/metag_da.c:661: warning: data definition has no type or storage class > >drivers/tty/metag_da.c:661: warning: type defaults to ‘int’ in declaration of ‘module_exit’ > >drivers/tty/metag_da.c:661: warning: parameter names (without types) in function declaration > >drivers/tty/metag_da.c:572: warning: ‘dashtty_init’ defined but not used > >drivers/tty/metag_da.c:645: warning: ‘dashtty_exit’ defined but not used > >drivers/tty/metag_da.c In function ‘dash_console_write’: > >drivers/tty/metag_da.c:670 : warning: passing argument 4 of ‘chancall’ discards qualifiers from pointer target type > > > >Instead of just adding the module.h include, now would be a good time to > >remove the use of these macros, replacing the module_init with > >device_initcall, and removing the exit function altogether since it > >isn't needed. If module support is added later the code can always be > >resurrected. > > > >Reported-by: Guenter Roeck > >Signed-off-by: James Hogan > >Cc: Greg Kroah-Hartman > >Cc: Jiri Slaby > >Cc: Paul Gortmaker > >Cc: linux-metag@vger.kernel.org > > Yes, that does the trick. > > Tested-by: Guenter Roeck Thanks guys, I'll add that to the module_init-device_initcall conversion branch, which will put it ahead of the code relocation commit. I think most other arch run with -Werror-implicit (or whatever it is) so that these kinds of things would not "leak" past into a silent boot fail like this. Paul. -- > > Thanks, > Guenter >