From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbbFHKdk (ORCPT ); Mon, 8 Jun 2015 06:33:40 -0400 Received: from mga03.intel.com ([134.134.136.65]:12023 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbbFHKdc (ORCPT ); Mon, 8 Jun 2015 06:33:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,573,1427785200"; d="scan'208";a="583969345" Date: Mon, 8 Jun 2015 16:04:47 +0530 From: Vinod Koul To: Maxime Ripard Cc: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lior Amsalem , Thomas Petazzoni Subject: Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode Message-ID: <20150608103447.GE28601@localhost> References: <1432645656-20504-1-git-send-email-maxime.ripard@free-electrons.com> <1432645656-20504-4-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432645656-20504-4-git-send-email-maxime.ripard@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > From: Lior Amsalem > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of > the descriptor and not set through the controller registers. > > This new feature allows mixing of different commands (even PQ) on the same > channel/chain without the need to stop the engine to reconfigure the engine > mode. > > Refactor the driver to be able to use that new feature on the Armada 38x, > while keeping the old behaviour on the older SoCs. > > Signed-off-by: Lior Amsalem > Reviewed-by: Ofer Heifetz > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +- > drivers/dma/mv_xor.c | 82 ++++++++++++++++++++---- > drivers/dma/mv_xor.h | 7 ++ > 3 files changed, 76 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documentation/devicetree/bindings/dma/mv-xor.txt > index 7c6cb7fcecd2..cc29c35266e2 100644 > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt > @@ -1,7 +1,7 @@ > * Marvell XOR engines > > Required properties: > -- compatible: Should be "marvell,orion-xor" > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor" marvell,armada-380-xor doesnt seem to exist in binding ? -- ~Vinod