From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Milos Vyletel <milos@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, Don Zickus <dzickus@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
"open list:PERFORMANCE EVENT..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: avoid possible race condition in copyfile
Date: Mon, 8 Jun 2015 10:39:57 -0300 [thread overview]
Message-ID: <20150608133957.GB3136@kernel.org> (raw)
In-Reply-To: <20150604091100.GA19775@gmail.com>
Em Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar escreveu:
> * Milos Vyletel <milos@redhat.com> wrote:
> > On top of that slow_copyfile no longer needs to deal with file mode when
> > creating file since temporary file is already created and mode is set.
> >
> > Signed-off-by: Milos Vyletel <milos@redhat.com>
>
> Ok, that looks nice!
>
> Assuming it passes testing you can add my ack to it:
>
> Acked-by: Ingo Molnar <mingo@kernel.org>
Can you please try applying it on tip/perf/core instead? I think it is
clashing with:
commit 9c9f5a2f1944e8b6bf2b618d04b31e1c1760637e
Author: Namhyung Kim <namhyung@kernel.org>
Date: Mon May 18 09:30:18 2015 +0900
perf tools: Introduce copyfile_offset() function
- Arnaldo
next prev parent reply other threads:[~2015-06-08 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 8:44 [PATCH] perf tools: avoid possible race condition in copyfile Milos Vyletel
2015-06-04 9:11 ` Ingo Molnar
2015-06-04 9:45 ` Milos Vyletel
2015-06-08 13:39 ` Arnaldo Carvalho de Melo [this message]
2015-06-08 13:58 ` Milos Vyletel
2015-06-08 14:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608133957.GB3136@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dzickus@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milos@redhat.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox