Re: [PATCH] perf tools: avoid possible race condition in copyfile

Milos Vyletel
2015-06-08T14:01:46Z

On Mon, Jun 08, 2015 at 10:39:57AM -0300, Arnaldo Carvalho de Melo wrote:

> Em Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar escreveu:
> > * Milos Vyletel <milos@redhat.com> wrote:
> > > On top of that slow_copyfile no longer needs to deal with file mode when
> > > creating file since temporary file is already created and mode is set.
> > >
> > > Signed-off-by: Milos Vyletel <milos@redhat.com>
> >
> > Ok, that looks nice!
> >
> > Assuming it passes testing you can add my ack to it:
> >
> > Acked-by: Ingo Molnar <mingo@kernel.org>
>
> Can you please try applying it on tip/perf/core instead? I think it is
> clashing with:
>
> commit 9c9f5a2f1944e8b6bf2b618d04b31e1c1760637e
> Author: Namhyung Kim <namhyung@kernel.org>
> Date: Mon May 18 09:30:18 2015 +0900
>
> perf tools: Introduce copyfile_offset() function
>

And also with

commit 0b1de0be1eac7b23e89cb43c17b02d38ead6b6c8
Author: Namhyung Kim <namhyung@kernel.org>
Date: Mon May 18 09:30:17 2015 +0900

perf tools: Add rm_rf() utility function

Will resend version based on tip/perf/core after I rerun my testing.

Milos