From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932107AbbFHTfV (ORCPT ); Mon, 8 Jun 2015 15:35:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57231 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbbFHTfP (ORCPT ); Mon, 8 Jun 2015 15:35:15 -0400 Date: Mon, 8 Jun 2015 12:35:14 -0700 From: Greg Kroah-Hartman To: Tolga Ceylan Cc: Oleg Drokin , Andreas Dilger , Julia Lawall , Arjun AK , Greg Donald , Darshana Padmadas , Joe Perches , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning Message-ID: <20150608193514.GA1044@kroah.com> References: <1433362810-14176-1-git-send-email-tolga.ceylan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433362810-14176-1-git-send-email-tolga.ceylan@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 01:20:10PM -0700, Tolga Ceylan wrote: > In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock) > warning due its inability to detect the noreturn attribute in > lbug_with_lock() function inside LBUG macro. With this patch, we unlock > the spinlock before checking the error condition to resolve this warning. That's a bug in sparse, not in the code, please don't work around tool bugs by changing kernel code. thanks, greg k-h