* [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c
@ 2015-05-28 8:24 Harisangam, Sharvari (S.)
2015-05-29 15:54 ` FW: " Harisangam, Sharvari (S.)
0 siblings, 1 reply; 5+ messages in thread
From: Harisangam, Sharvari (S.) @ 2015-05-28 8:24 UTC (permalink / raw)
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
tvboxspy@gmail.com, gclement@baobob.org, haticeerturk27@gmail.com,
mahfouz.saif.elyazal@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari <sharisan@visteon.com>
---
drivers/staging/vt6655/rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 7468776..7fedde3 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -1093,7 +1093,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
@@ -1115,7 +1115,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
@@ -1138,7 +1138,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
} else {/* 802.11a/b packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {
+ if (bRTS) {
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
@@ -1158,7 +1158,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) { /* RTS_need */
+ if (bRTS) { /* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c
2015-05-28 8:24 [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c Harisangam, Sharvari (S.)
@ 2015-05-29 15:54 ` Harisangam, Sharvari (S.)
2015-05-31 1:33 ` gregkh
2015-06-01 4:16 ` Harisangam, Sharvari (S.)
0 siblings, 2 replies; 5+ messages in thread
From: Harisangam, Sharvari (S.) @ 2015-05-29 15:54 UTC (permalink / raw)
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
tvboxspy@gmail.com, gclement@baobob.org, haticeerturk27@gmail.com,
mahfouz.saif.elyazal@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari <sharisan@visteon.com>
---
drivers/staging/vt6655/rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 7468776..7fedde3 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -1093,7 +1093,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); @@ -1115,7 +1115,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); @@ -1138,7 +1138,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
} else {/* 802.11a/b packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {
+ if (bRTS) {
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); @@ -1158,7 +1158,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) { /* RTS_need */
+ if (bRTS) { /* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c
2015-05-29 15:54 ` FW: " Harisangam, Sharvari (S.)
@ 2015-05-31 1:33 ` gregkh
2015-06-01 4:16 ` Harisangam, Sharvari (S.)
1 sibling, 0 replies; 5+ messages in thread
From: gregkh @ 2015-05-31 1:33 UTC (permalink / raw)
To: Harisangam, Sharvari (S.)
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
gclement@baobob.org, haticeerturk27@gmail.com,
mahfouz.saif.elyazal@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Fri, May 29, 2015 at 03:54:27PM +0000, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
> This change was detected with the help of coccinelle tool
>
> Signed-off-by: Harisangam Sharvari <sharisan@visteon.com>
> ---
> drivers/staging/vt6655/rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Why did you resend this with a forward?
Which one should I take?
I'm going to drop both as I don't know what to do, please resend the one
you wish to have applied.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c
2015-05-29 15:54 ` FW: " Harisangam, Sharvari (S.)
2015-05-31 1:33 ` gregkh
@ 2015-06-01 4:16 ` Harisangam, Sharvari (S.)
2015-06-08 20:21 ` gregkh
1 sibling, 1 reply; 5+ messages in thread
From: Harisangam, Sharvari (S.) @ 2015-06-01 4:16 UTC (permalink / raw)
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
tvboxspy@gmail.com, gclement@baobob.org, haticeerturk27@gmail.com,
mahfouz.saif.elyazal@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Sharvari Harisangam <sharisan@visteon.com>
Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
This change was detected with the help of coccinelle tool
Signed-off-by: Sharvari Harisangam <sharisan@visteon.com>
---
drivers/staging/vt6655/rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 7468776..7fedde3 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -1093,7 +1093,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); @@ -1115,7 +1115,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); @@ -1138,7 +1138,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
} else {/* 802.11a/b packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {
+ if (bRTS) {
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); @@ -1158,7 +1158,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) { /* RTS_need */
+ if (bRTS) { /* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c
2015-06-01 4:16 ` Harisangam, Sharvari (S.)
@ 2015-06-08 20:21 ` gregkh
0 siblings, 0 replies; 5+ messages in thread
From: gregkh @ 2015-06-08 20:21 UTC (permalink / raw)
To: Harisangam, Sharvari (S.)
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
gclement@baobob.org, haticeerturk27@gmail.com,
mahfouz.saif.elyazal@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Mon, Jun 01, 2015 at 04:16:50AM +0000, Harisangam, Sharvari (S.) wrote:
> From: Sharvari Harisangam <sharisan@visteon.com>
>
> Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
> This change was detected with the help of coccinelle tool
>
> Signed-off-by: Sharvari Harisangam <sharisan@visteon.com>
> ---
> drivers/staging/vt6655/rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
This patch can not be applied to my tree :(
Please fix it up and resend.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-08 20:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-28 8:24 [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c Harisangam, Sharvari (S.)
2015-05-29 15:54 ` FW: " Harisangam, Sharvari (S.)
2015-05-31 1:33 ` gregkh
2015-06-01 4:16 ` Harisangam, Sharvari (S.)
2015-06-08 20:21 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox