From: Borislav Petkov <bp@suse.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Chen, Gong" <gong.chen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4 Rebase] x86, MCE: Avoid potential deadlock in MCE context
Date: Mon, 8 Jun 2015 22:26:58 +0200 [thread overview]
Message-ID: <20150608202658.GF5877@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A8E51A@ORSMSX114.amr.corp.intel.com>
On Mon, Jun 08, 2015 at 08:03:08PM +0000, Luck, Tony wrote:
> @@ -156,7 +156,8 @@ void mce_log(struct mce *mce)
> /* Emit the trace record: */
> trace_mce_record(mce);
>
> - atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, mce);
> + mce_genpool_add(mce);
> + irq_work_queue(&mce_irq_work);
>
> Is it safe to call irq_work_queue() from MCE context?
Yeah, we're using it in contexts like:
do_nmi
|-> default_do_nmi
|-> nmi_handle
|->irq_work_queue
for example. I think that is good enough for #MC. :)
> If that is OK, then I don't have any concerns.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-06-08 20:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 19:35 MCE ring buffer management (Rebase) Chen, Gong
2015-05-20 19:35 ` [PATCH 1/4 Rebase] x86, MCE: Provide a lock-less memory pool to save error record Chen, Gong
2015-05-20 10:36 ` Borislav Petkov
2015-05-22 21:06 ` Chen, Gong
2015-05-22 8:17 ` Borislav Petkov
2015-05-20 19:35 ` [PATCH 2/4 Rebase] x86, MCE: Don't use percpu for MCE workqueue/irq_work Chen, Gong
2015-05-20 19:35 ` [PATCH 3/4 Rebase] x86, MCE: Remove mce_ring for SRAO error Chen, Gong
2015-05-20 19:35 ` [PATCH 4/4 Rebase] x86, MCE: Avoid potential deadlock in MCE context Chen, Gong
2015-05-20 9:28 ` Borislav Petkov
2015-05-22 21:12 ` Chen, Gong
2015-05-22 9:09 ` Borislav Petkov
2015-06-08 13:41 ` Borislav Petkov
2015-06-08 20:03 ` Luck, Tony
2015-06-08 20:26 ` Borislav Petkov [this message]
2015-06-11 8:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608202658.GF5877@pd.tnic \
--to=bp@suse.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox