From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932463AbbFHUzO (ORCPT ); Mon, 8 Jun 2015 16:55:14 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50338 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932339AbbFHUzE (ORCPT ); Mon, 8 Jun 2015 16:55:04 -0400 Date: Mon, 8 Jun 2015 22:53:51 +0200 From: Maxime Ripard To: Vinod Koul Cc: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lior Amsalem , Thomas Petazzoni Subject: Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode Message-ID: <20150608205351.GC23777@lukather> References: <1432645656-20504-1-git-send-email-maxime.ripard@free-electrons.com> <1432645656-20504-4-git-send-email-maxime.ripard@free-electrons.com> <20150608103447.GE28601@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YOiw+WO4Gc95oc3L" Content-Disposition: inline In-Reply-To: <20150608103447.GE28601@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YOiw+WO4Gc95oc3L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Vinod, On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote: > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > > From: Lior Amsalem > >=20 > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be par= t of > > the descriptor and not set through the controller registers. > >=20 > > This new feature allows mixing of different commands (even PQ) on the s= ame > > channel/chain without the need to stop the engine to reconfigure the en= gine > > mode. > >=20 > > Refactor the driver to be able to use that new feature on the Armada 38= x, > > while keeping the old behaviour on the older SoCs. > >=20 > > Signed-off-by: Lior Amsalem > > Reviewed-by: Ofer Heifetz > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +- > > drivers/dma/mv_xor.c | 82 ++++++++++++++++= ++++---- > > drivers/dma/mv_xor.h | 7 ++ > > 3 files changed, 76 insertions(+), 15 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documen= tation/devicetree/bindings/dma/mv-xor.txt > > index 7c6cb7fcecd2..cc29c35266e2 100644 > > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt > > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt > > @@ -1,7 +1,7 @@ > > * Marvell XOR engines > > =20 > > Required properties: > > -- compatible: Should be "marvell,orion-xor" > > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor" > > marvell,armada-380-xor doesnt seem to exist in binding ? I'm not sure what you mean, this patch precisely adds that compatible to the bindings documentation. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --YOiw+WO4Gc95oc3L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVdgDfAAoJEBx+YmzsjxAgmjkP/2t66PGaOzWPefjxutxUyfjI ymoJocB+nqkQuLuD7jjlBVa56gDP19nyfQbqSpJjeylagg0cpDz4A4TDZ9Ml1Qzy OBGTrasHhCHRAhh8X+/tAbeIZgUL7HjsWPQQgwthPALVxjHtE0PJMf40Z0EfA0MG 7RD56FUG/yiFuAsNtlRsxdzhHqCqRhn24lMClDs3vubuaCetnBqM5xHr9Pi8Xeus UpYPSiERMNS0xEFigGrPxtdOFOnXYCw0LzHnSQXAIkWb3oiP0awrUFzGosJqLFD2 vmO7SsNt+zeIGLGW4pV/McHQQgzX1ks4Gb83HiSroGfs/h5GoTOfrmTOa9x94fLs 3m+UD9y1+GXpfR6chxPAAX0ul1xLG6L0ROOZ5dW6jYgyYLsMLZcjgf5KCImANyuP 39lNcRpsR2ppErhvxESco7ZXP3Ck0ktGRbuMu6XjqxowuRCRoje1BsxpS4XuJZM5 8yZTV2s3ob8COSpHcBn5yykF/UGDv1mP1LhI239sIOCYl4v8QIOAPt0C9qc0TdYM phuF8ew5QDrIhtbQ3RTSvvS/kEUQnwI2EuUBQh85EazkTgGEWpqQLfvoBDk0FMOO Syv7dfY2dJZayKdz6Fwy1p0RTCRzVsV/NroF7wNeoocVyqIDMTaCunR0oy3K5tbD aArjRbyl7LlUxCH2M30C =LGeY -----END PGP SIGNATURE----- --YOiw+WO4Gc95oc3L--