Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate

Christoph Hellwig
2015-06-09T06:39:13Z

> +#include <asm-generic/io-64-nonatomic-lo-hi.h>
> +
> +#ifndef __io_virt
> +#define __io_virt(x) ((void __force *) (x))
> +#endif

NAK. driver code mus never include asm-generic headers directly,
and __io_virt isn't something that's up to a driver to redefine either.

I think we really need the memremap series in first before trying to
do the things done in this patch.