Re: [PATCH v5 17/21] libnvdimm: infrastructure for btt devices

Christoph Hellwig
2015-06-11T07:28:22Z

On Wed, Jun 10, 2015 at 02:46:16PM -0400, Matthew Wilcox wrote:
> Don't screw up rw_page. The point of rw_page is to read or write a page
> cache page. It can sleep, and it indicates success by using the page
> flags. Don't try and scqueeze rw_bytes into it. If you want rw_bytes
> to be a queue operation, that's one thing, but don't mess with rw_page.

Oh, I forgot about the page manipulating nature. Yes, we'll need a different
operation in this case.