From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbbFIHzF (ORCPT ); Tue, 9 Jun 2015 03:55:05 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38426 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbFIHy6 (ORCPT ); Tue, 9 Jun 2015 03:54:58 -0400 Date: Tue, 9 Jun 2015 08:54:52 +0100 From: Lee Jones To: Fabio Estevam Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Message-ID: <20150609075452.GG2982@x1> References: <1431801737-9027-1-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431801737-9027-1-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 May 2015, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam > --- > drivers/mfd/twl4030-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c > index 1b772ef..a3fa7f4 100644 > --- a/drivers/mfd/twl4030-irq.c > +++ b/drivers/mfd/twl4030-irq.c > @@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base) > irq_set_handler_data(irq, agent); > agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name); > status = request_threaded_irq(irq, NULL, handle_twl4030_sih, > - IRQF_EARLY_RESUME, > + IRQF_EARLY_RESUME | IRQF_ONESHOT, > agent->irq_name ?: sih->name, NULL); > > dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog