From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbbFIHzt (ORCPT ); Tue, 9 Jun 2015 03:55:49 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33291 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbbFIHzo (ORCPT ); Tue, 9 Jun 2015 03:55:44 -0400 Date: Tue, 9 Jun 2015 08:55:38 +0100 From: Lee Jones To: Fabio Estevam Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH 4/8] mfd: htc-i2cpld: Pass the IRQF_ONESHOT flag Message-ID: <20150609075538.GJ2982@x1> References: <1431801737-9027-1-git-send-email-festevam@gmail.com> <1431801737-9027-4-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431801737-9027-4-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 May 2015, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam > --- > drivers/mfd/htc-i2cpld.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c > index ebb9cf1..b54baad 100644 > --- a/drivers/mfd/htc-i2cpld.c > +++ b/drivers/mfd/htc-i2cpld.c > @@ -564,7 +564,8 @@ static int htcpld_core_probe(struct platform_device *pdev) > htcpld->chained_irq = res->start; > > /* Setup the chained interrupt handler */ > - flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING; > + flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | > + IRQF_ONESHOT; > ret = request_threaded_irq(htcpld->chained_irq, > NULL, htcpld_handler, > flags, pdev->name, htcpld); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog