Re: [PATCH 5/8] mfd: wm8350-core: Pass the IRQF_ONESHOT flag

[Lee Jones <lee.jones@linaro.org>]

On Sat, 16 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
> 
> So pass the IRQF_ONESHOT flag in this case.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/mfd/wm8350-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index f5124a8..8a07c56 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -404,7 +404,8 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
>  	if (wm8350->irq_base) {
>  		ret = request_threaded_irq(wm8350->irq_base +
>  					   WM8350_IRQ_AUXADC_DATARDY,
> -					   NULL, wm8350_auxadc_irq, 0,
> +					   NULL, wm8350_auxadc_irq,
> +					   IRQF_ONESHOT,
>  					   "auxadc", wm8350);
>  		if (ret < 0)
>  			dev_warn(wm8350->dev,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog