From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932696AbbFIH4G (ORCPT ); Tue, 9 Jun 2015 03:56:06 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:33713 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbbFIHz5 (ORCPT ); Tue, 9 Jun 2015 03:55:57 -0400 Date: Tue, 9 Jun 2015 08:55:51 +0100 From: Lee Jones To: Fabio Estevam Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH 5/8] mfd: wm8350-core: Pass the IRQF_ONESHOT flag Message-ID: <20150609075551.GK2982@x1> References: <1431801737-9027-1-git-send-email-festevam@gmail.com> <1431801737-9027-5-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431801737-9027-5-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 May 2015, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam > --- > drivers/mfd/wm8350-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c > index f5124a8..8a07c56 100644 > --- a/drivers/mfd/wm8350-core.c > +++ b/drivers/mfd/wm8350-core.c > @@ -404,7 +404,8 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, > if (wm8350->irq_base) { > ret = request_threaded_irq(wm8350->irq_base + > WM8350_IRQ_AUXADC_DATARDY, > - NULL, wm8350_auxadc_irq, 0, > + NULL, wm8350_auxadc_irq, > + IRQF_ONESHOT, > "auxadc", wm8350); > if (ret < 0) > dev_warn(wm8350->dev, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog