Re: [PATCH 7/8] mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag

[Lee Jones <lee.jones@linaro.org>]

On Sat, 16 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
> 
> So pass the IRQF_ONESHOT flag in this case.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/mfd/ab8500-gpadc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index dabbc93..c51c1b1 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
>  	if (gpadc->irq_sw >= 0) {
>  		ret = request_threaded_irq(gpadc->irq_sw, NULL,
>  			ab8500_bm_gpadcconvend_handler,
> -			IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw",
> +			IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
> +			"ab8500-gpadc-sw",
>  			gpadc);
>  		if (ret < 0) {
>  			dev_err(gpadc->dev,
> @@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
>  	if (gpadc->irq_hw >= 0) {
>  		ret = request_threaded_irq(gpadc->irq_hw, NULL,
>  			ab8500_bm_gpadcconvend_handler,
> -			IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw",
> +			IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
> +			"ab8500-gpadc-hw",
>  			gpadc);
>  		if (ret < 0) {
>  			dev_err(gpadc->dev,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog