From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932827AbbFIH4e (ORCPT ); Tue, 9 Jun 2015 03:56:34 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:36037 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932493AbbFIH4Y (ORCPT ); Tue, 9 Jun 2015 03:56:24 -0400 Date: Tue, 9 Jun 2015 08:56:17 +0100 From: Lee Jones To: Fabio Estevam Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH 7/8] mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag Message-ID: <20150609075617.GM2982@x1> References: <1431801737-9027-1-git-send-email-festevam@gmail.com> <1431801737-9027-7-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431801737-9027-7-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 May 2015, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam > --- > drivers/mfd/ab8500-gpadc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c > index dabbc93..c51c1b1 100644 > --- a/drivers/mfd/ab8500-gpadc.c > +++ b/drivers/mfd/ab8500-gpadc.c > @@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) > if (gpadc->irq_sw >= 0) { > ret = request_threaded_irq(gpadc->irq_sw, NULL, > ab8500_bm_gpadcconvend_handler, > - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw", > + IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT, > + "ab8500-gpadc-sw", > gpadc); > if (ret < 0) { > dev_err(gpadc->dev, > @@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) > if (gpadc->irq_hw >= 0) { > ret = request_threaded_irq(gpadc->irq_hw, NULL, > ab8500_bm_gpadcconvend_handler, > - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw", > + IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT, > + "ab8500-gpadc-hw", > gpadc); > if (ret < 0) { > dev_err(gpadc->dev, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog