From: Peter Zijlstra <peterz@infradead.org>
To: Huang Rui <ray.huang@amd.com>
Cc: "Borislav Petkov" <bp@suse.de>,
"Andy Lutomirski" <luto@amacapital.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Aaron Lu" <aaron.lu@intel.com>,
"Suravee Suthikulanit" <suravee.suthikulpanit@amd.com>,
"Tony Li" <tony.li@amd.com>, "Ken Xue" <ken.xue@amd.com>
Subject: Re: [PATCH v2 1/4] x86, mwaitt: add monitorx and mwaitx instruction
Date: Tue, 9 Jun 2015 10:23:06 +0200 [thread overview]
Message-ID: <20150609082306.GN3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1433819621-15093-2-git-send-email-ray.huang@amd.com>
On Tue, Jun 09, 2015 at 11:13:38AM +0800, Huang Rui wrote:
>
> MWAITX ECX[1]: enable timer if set
> MWAITX EBX[31:0]: max wait time expressed in SW P0 clocks
>
> The software P0 frequency is the same as the TSC frequency.
>
> Max timeout = EBX/(TSC frequency)
^ that, would make a lovely comment for this v
> +static inline void __mwaitx(unsigned long eax, unsigned long ebx,
> + unsigned long ecx)
> +{
> + /* "mwaitx %eax, %ebx, %ecx;" */
> + asm volatile(".byte 0x0f, 0x01, 0xfb;"
> + :: "a" (eax), "b" (ebx), "c" (ecx));
> +}
next prev parent reply other threads:[~2015-06-09 8:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 3:13 [PATCH v2 0/4] x86, mwaitt: introduce AMD mwaitt support Huang Rui
2015-06-09 3:13 ` [PATCH v2 1/4] x86, mwaitt: add monitorx and mwaitx instruction Huang Rui
2015-06-09 8:23 ` Peter Zijlstra [this message]
2015-06-09 9:48 ` Huang Rui
2015-06-09 10:05 ` Borislav Petkov
2015-06-09 16:44 ` Andy Lutomirski
2015-06-09 17:06 ` Borislav Petkov
2015-06-10 2:40 ` Huang Rui
2015-06-09 3:13 ` [PATCH v2 2/4] x86, mwaitt: make delay method configurable Huang Rui
2015-06-09 9:05 ` Borislav Petkov
2015-06-09 9:31 ` Peter Zijlstra
2015-06-09 10:03 ` Huang Rui
2015-06-09 10:08 ` Peter Zijlstra
2015-06-09 10:15 ` Huang Rui
2015-06-09 10:08 ` Borislav Petkov
2015-06-09 3:13 ` [PATCH v2 3/4] x86, mwaitt: introduce mwaix delay with a configurable timer Huang Rui
2015-06-09 8:31 ` Peter Zijlstra
2015-06-09 10:10 ` Huang Rui
2015-06-09 9:29 ` Peter Zijlstra
2015-06-09 10:59 ` Huang Rui
2015-06-09 16:46 ` Andy Lutomirski
2015-06-09 17:13 ` Peter Zijlstra
2015-06-09 17:55 ` Andy Lutomirski
2015-06-09 18:43 ` Borislav Petkov
2015-06-09 18:55 ` Andy Lutomirski
2015-06-12 8:42 ` Borislav Petkov
2015-06-12 23:15 ` Andy Lutomirski
2015-06-13 8:48 ` Borislav Petkov
2015-06-09 3:13 ` [PATCH v2 4/4] x86, mwaitt: add documents of delay option Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609082306.GN3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aaron.lu@intel.com \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=ken.xue@amd.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=ray.huang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.li@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox