Re: [PATCH 5/6] power: user: Standardize "Syncing filesystems ..." message

Joe Perches
2015-06-05T15:07:48Z

On Fri, 2015-06-05 at 12:37 +0200, Pavel Machek wrote:
> On Thu 2015-06-04 11:36:48, Joe Perches wrote:
> > Instead of a two individual printks that would generally be
> > emitted on a single line, emit 2 lines to make the start
> > and end of the synchronization more easily timeable.
[]
> > diff --git a/kernel/power/user.c b/kernel/power/user.c
[]
> > @@ -221,9 +221,9 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd,
> > if (data->frozen)
> > break;
> >
> > - printk("Syncing filesystems ... ");
> > + printk("Syncing filesystems ...\n");
> > sys_sync();
> > - printk("done.\n");
> > + printk("Syncing filesystems: done\n");
>
> You converted " ..." -> "..." elsewhere, so why not here?

Missed that one.

> Is splitting message to two lines a good idea?

I think the "done" is unnecessary actually.

As there's no newline on the first, printk is
async and can be interleaved by other threads.