From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932838AbbFIKXR (ORCPT ); Tue, 9 Jun 2015 06:23:17 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:32878 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187AbbFIKXH (ORCPT ); Tue, 9 Jun 2015 06:23:07 -0400 Date: Tue, 9 Jun 2015 12:23:02 +0200 From: Ingo Molnar To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, dave.hansen@linux.intel.com Subject: Re: [PATCH 18/19] x86, mpx: do not count MPX VMAs as neighbors when unmapping Message-ID: <20150609102302.GA32447@gmail.com> References: <20150607183700.7E78D631@viggo.jf.intel.com> <20150607183706.A6BD90BF@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150607183706.A6BD90BF@viggo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dave Hansen wrote: > diff -puN arch/x86/mm/mpx.c~mpx-dont-count-mpx-vmas-as-neighbors arch/x86/mm/mpx.c > --- a/arch/x86/mm/mpx.c~mpx-dont-count-mpx-vmas-as-neighbors 2015-06-01 10:24:10.037992968 -0700 > +++ b/arch/x86/mm/mpx.c 2015-06-01 10:24:10.040993104 -0700 > @@ -937,16 +937,30 @@ static int try_unmap_single_bt(struct mm > void __user *bde_vaddr; > int ret; > /* > + * We already unliked the VMAs from the mm's rbtree so 'start' > + * is guaranteed to be in a hole. This gets us the first VMA > + * before the hole in to 'prev' and the next VMA after the hole > + * in to 'next'. Hey, I didn't know VMAs were on Facebook ;-) I fixed it up to 'unlinked'. Thanks, Ingo