From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933138AbbFILH2 (ORCPT ); Tue, 9 Jun 2015 07:07:28 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:33691 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933103AbbFILHN (ORCPT ); Tue, 9 Jun 2015 07:07:13 -0400 Date: Tue, 9 Jun 2015 12:07:08 +0100 From: Lee Jones To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Subject: Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away Message-ID: <20150609110708.GR2982@x1> References: <1433529771-24496-1-git-send-email-lee.jones@linaro.org> <1433529771-24496-6-git-send-email-lee.jones@linaro.org> <20150608180718.GR14071@sirena.org.uk> <20150609070347.GE2982@x1> <20150609101005.GZ14071@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150609101005.GZ14071@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Jun 2015, Mark Brown wrote: > On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote: > > > Admittedly this is an extreme example, but I do consider: > > > init_data = of_get_regulator_init_data(); > > if (init_data) > > return -ENOMEM; > > > ... neater than: > > > config.init_data = of_get_regulator_init_data(); > > if (!config.init_data) > > return -ENOMEM; > > Oh, I see. I pretty much see things the other way for things where the > temporary has no other users. I don't feel passionate enough about it to contest. Skip this patch then. Are you okay to continue the review? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog