From: Dan Carpenter <dan.carpenter@oracle.com>
To: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"mdcasey@chabloom.com" <mdcasey@chabloom.com>,
"behanw@converseincode.com" <behanw@converseincode.com>,
"mateusz.kulikowski@gmail.com" <mateusz.kulikowski@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] Staging: rtl8192e: Casting correct Endianness
Date: Tue, 9 Jun 2015 16:55:53 +0300 [thread overview]
Message-ID: <20150609135553.GX28762@mwanda> (raw)
In-Reply-To: <20150609122508.GA4375@visteon-gnana>
On Tue, Jun 09, 2015 at 12:22:27PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal <gdhanapa@visteon.com>
>
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
>
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> ---
> v4: Greg review comments addressed
Which ones?
> @@ -2244,8 +2244,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
> struct rtllib_assoc_response_frame *assoc_resp;
> struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data;
>
> + u16 frame_ctl = le16_to_cpu(header->frame_ctl);
> netdev_dbg(ieee->dev, "received [RE]ASSOCIATION RESPONSE (%d)\n",
> - WLAN_FC_GET_STYPE(header->frame_ctl));
> + WLAN_FC_GET_STYPE(frame_ctl));
>
Blank line in the wrong spot.
regards,
dan carpenter
prev parent reply other threads:[~2015-06-09 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 12:22 [PATCH v4] Staging: rtl8192e: Casting correct Endianness DHANAPAL, GNANACHANDRAN (G.)
2015-06-09 13:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609135553.GX28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=behanw@converseincode.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdhanapa@visteon.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=mdcasey@chabloom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox