public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Heinz Diehl <htd+ml@fritha.org>,
	linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: Re: NILFS2: double uuid
Date: Tue, 9 Jun 2015 16:07:42 +0200	[thread overview]
Message-ID: <20150609140742.GH1992@ws.net.home> (raw)
In-Reply-To: <5576E44F.5030201@lab.ntt.co.jp>

On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote:
> $ sudo nilfs-resize -y /dev/sdb1 1G
> Partition size = 2146435072 bytes.
> Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes.
> 128 segments will be truncated from segnum 127.
> Moving 103 in-use segments.
> progress |***********************************************|
> Done.
> 
> $ sudo umount /test
> $ sudo mount /dev/sdb1 /test
> $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f
> NAME   FSTYPE  LABEL           UUID MOUNTPOINT
> [...]
> sdb
> `-sdb1                                                              /test
> 
> This blank state continued until I shrank the partition or
> re-extended the filesystem to the partition size.
> 
> Could you consider confining the s_dev_size test only to the
> backup superblock ?

Hmm... why nilfs-resize does not update the size in the superblock?
It seems like nilfs-resize bug.

> It seems that we don't have to drop the primary super block
> even if s_dev_size doesn't fit to the partition size.

Yes, fixed. I have also enabled the s_dev_size check for whole-disk
devices only to minimize number of situations when we rely on the
s_dev_size.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2015-06-09 14:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08  6:43 NILFS2: double uuid Heinz Diehl
2015-06-08  6:47 ` Heinz Diehl
2015-06-08  8:18 ` Ryusuke Konishi
2015-06-08  9:45   ` Heinz Diehl
2015-06-08 10:08     ` Heinz Diehl
2015-06-08 10:12       ` Heinz Diehl
2015-06-08 10:31       ` Ryusuke Konishi
2015-06-08 15:31         ` Ryusuke Konishi
2015-06-08 17:23           ` Heinz Diehl
2015-06-09  5:45             ` Heinz Diehl
2015-06-09  8:53           ` Karel Zak
2015-06-09  9:46             ` Heinz Diehl
2015-06-09 13:04             ` Ryusuke Konishi
2015-06-09 14:07               ` Karel Zak [this message]
2015-06-09 16:00                 ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609140742.GH1992@ws.net.home \
    --to=kzak@redhat.com \
    --cc=htd+ml@fritha.org \
    --cc=konishi.ryusuke@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nilfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox