Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Tue, Jun 09, 2015 at 05:13:56PM +0100, Richard Fitzgerald wrote:
> On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote:

> > I'm still not a big fan of the double registration that's being done -
> > if nothing else the fact that it's not also factoring out the creation
> > of the DSP controls seems wrong.

> I don't see the point of trying to fight against the design of ASoC with
> the second probe. ASoC gives us what we need at the codec_probe stage
> so why try to invent something different?

Well, you could've still hung things off the struct device - it's not
like the ASoC level device is a requirement here - and like I say the
fact that it's not actually factoring out the initialisation that's
already happening at the ASoC probe isn't good.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]