Re: [PATCH 0/3] Switch input leds over to standard LED class devices

Dmitry Torokhov
2015-06-08T23:16:38Z

On Tue, Jun 09, 2015 at 12:58:11AM +0200, Bastien Nocera wrote:
> On Mon, 2015-06-08 at 14:43 -0700, Dmitry Torokhov wrote:
> > Hi,
> >
> > I finally was able to spend some time looking over Samuel's patch set
> > switching input LEDs from custom implementation over to standard LED
> > class
> > devices and I think this is the shape I am reasonably happy with. The
> > changes:
> >
> <snip>
> > 2. There are no per-input device triggers. Input devices only carry
> > LEDs
> > and those LEDs use one of the system-wide triggers. Which ones is to
> > user
> > to decide. The default triggers are the one defines by keyboard
> > handler for
> > it's standard LED states.
> >
> <snip>
> > Please take a look and see if you see any holes.
>
> What would the quirk for a keyboard not having LEDs look like?
>
> In GNOME, we want to pop up a on-screen display when pressing, say, the
> Caps Lock key on a keyboard that doesn't have any such keys (such as my
> Lenovo X1 Carbon and the Logitech K750 that's plugged into it in my
> case).

This is not really related to this patch set, but LED bitmap for input
devices is sent in their uevents so you can check it in udev. This will
assumes that input driver knows whether LED is present on device or not
(and for PS/2 keyboards it does not and assumes they are there so your
X1's keyboard tell you that it has 3 standard LEDs).

Thanks.

--
Dmitry