Re: [PATCH 0/3] Switch input leds over to standard LED class devices

Bastien Nocera
2015-06-08T22:58:24Z

On Mon, 2015-06-08 at 14:43 -0700, Dmitry Torokhov wrote:
> Hi,
>
> I finally was able to spend some time looking over Samuel's patch set
> switching input LEDs from custom implementation over to standard LED
> class
> devices and I think this is the shape I am reasonably happy with. The
> changes:
>
<snip>
> 2. There are no per-input device triggers. Input devices only carry
> LEDs
> and those LEDs use one of the system-wide triggers. Which ones is to
> user
> to decide. The default triggers are the one defines by keyboard
> handler for
> it's standard LED states.
>
<snip>
> Please take a look and see if you see any holes.

What would the quirk for a keyboard not having LEDs look like?

In GNOME, we want to pop up a on-screen display when pressing, say, the
Caps Lock key on a keyboard that doesn't have any such keys (such as my
Lenovo X1 Carbon and the Logitech K750 that's plugged into it in my
case).

Cheers