The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	ludovic.desroches@atmel.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	robh+dt@kernel.org
Subject: Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode
Date: Wed, 10 Jun 2015 07:19:37 +0900	[thread overview]
Message-ID: <20150609221936.GB1717@katana> (raw)
In-Reply-To: <55770F43.7050707@atmel.com>

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
> 
> No, please name it:
> 
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-06-09 22:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:25 [PATCH v5 0/6] i2c: at91: add support to FIFOs and alternative command Cyrille Pitchen
2015-06-03 16:25 ` [PATCH v5 1/6] i2c: at91: fix a race condition when using the DMA controller Cyrille Pitchen
2015-06-03 16:25 ` [PATCH v5 2/6] i2c: at91: use BIT() macro to define register bits Cyrille Pitchen
2015-06-03 16:25 ` [PATCH v5 3/6] i2c: at91: update documentation for DT bindings Cyrille Pitchen
2015-06-09 16:04   ` Nicolas Ferre
2015-06-03 16:25 ` [PATCH v5 4/6] i2c: at91: add support for new alternative command mode Cyrille Pitchen
2015-06-09 16:07   ` Nicolas Ferre
2015-06-09 22:19     ` Wolfram Sang [this message]
2015-06-03 16:25 ` [PATCH v5 5/6] i2c: at91: print hardware version Cyrille Pitchen
2015-06-03 16:25 ` [PATCH v5 6/6] i2c: at91: add support to FIFOs Cyrille Pitchen
2015-06-04  6:02 ` [PATCH v5 0/6] i2c: at91: add support to FIFOs and alternative command Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609221936.GB1717@katana \
    --to=wsa@the-dreams.de \
    --cc=cyrille.pitchen@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox