From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Jens Axboe <axboe@kernel.dk>, Zach Brown <zab@zabbo.net>,
Christoph Hellwig <hch@infradead.org>,
Maxim Patlasov <mpatlasov@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Tejun Heo <tj@kernel.org>, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v5 1/5] fs: direct-io: don't dirtying pages for ITER_BVEC/ITER_KVEC direct read
Date: Wed, 10 Jun 2015 00:35:26 -0700 [thread overview]
Message-ID: <20150610073526.GA6964@infradead.org> (raw)
In-Reply-To: <1433857766-6153-2-git-send-email-ming.lei@canonical.com>
On Tue, Jun 09, 2015 at 09:49:22PM +0800, Ming Lei wrote:
> When direct read IO is submitted from kernel, it is often
> unnecessary to dirty pages, for example of loop, dirtying pages
> have been considered in the upper filesystem(over loop) side
> already, and they don't need to be dirtied again.
>
> So this patch doesn't dirtying pages for ITER_BVEC/ITER_KVEC
> direct read, and loop should be the 1st case to use ITER_BVEC/ITER_KVEC
> for direct read I/O.
>
> The patch is based on previous Dave's patch.
Looks good, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-06-10 7:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 13:49 [PATCH v5 0/5] block: loop: improve loop with AIO Ming Lei
2015-06-09 13:49 ` [PATCH v5 1/5] fs: direct-io: don't dirtying pages for ITER_BVEC/ITER_KVEC direct read Ming Lei
2015-06-10 7:35 ` Christoph Hellwig [this message]
2015-06-09 13:49 ` [PATCH v5 2/5] block: loop: set QUEUE_FLAG_NOMERGES for request queue of loop Ming Lei
2015-06-10 7:36 ` Christoph Hellwig
2015-06-22 6:32 ` Ming Lei
2015-06-09 13:49 ` [PATCH v5 3/5] block: loop: use kthread_work Ming Lei
2015-06-09 13:49 ` [PATCH v5 4/5] block: loop: prepare for supporing direct IO Ming Lei
2015-06-10 7:40 ` Christoph Hellwig
2015-06-22 12:19 ` Ming Lei
2015-06-09 13:49 ` [PATCH v5 5/5] block: loop: support DIO & AIO Ming Lei
2015-06-10 7:46 ` Christoph Hellwig
2015-06-22 12:09 ` Ming Lei
2015-06-22 16:00 ` Christoph Hellwig
2015-06-23 2:59 ` Ming Lei
2015-06-23 12:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610073526.GA6964@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dave.kleikamp@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=mpatlasov@parallels.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox