Re: [PATCH 3/4] mm: Defer flush of writable TLB entries

Mel Gorman
2015-06-10T08:17:11Z

On Wed, Jun 10, 2015 at 09:50:34AM +0200, Ingo Molnar wrote:
>
> * Mel Gorman <mgorman@suse.de> wrote:
>
> > +
> > + /*
> > + * If the PTE was dirty then it's best to assume it's writable. The
> > + * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush()
> > + * before the page any IO is initiated.
> > + */
>
> Speling nit: "before the page any IO is initiated" does not parse for me.
>
> > + /*
> > + * Page is dirty. Flush the TLB if a writable entry
> > + * potentially exists to avoid CPU writes after IO
> > + * starts and then write it out here
> > + */
>
> s/here/here.
>
> or:
>
> s/here/here:
>

Both fixed, thanks.

--
Mel Gorman
SUSE Labs