Re: [RFC][PATCH] printk: Fixup the nmi printk mess

Peter Zijlstra
2015-06-25T18:15:11Z

On Fri, Jun 12, 2015 at 05:35:05PM +0200, Petr Mladek wrote:
> I have got another idea. We already use a lock to synchronize
> readers. It might be used to avoid the race and keep the global
> flush().
>
> I played with it, see below. It is based on 2nd Peter's patch
> where I modified only struct nmi_seq_buf, __printk_nmi_flush(),
> and vprintk_nmi().
>
> It forces the reader to flush everything or nothing. It is less
> effective than the previous code but much more simple.
>
> It seems to work but it is just a proof-of-concept. Also I think that
> it would be possible to use the normal seq_buf in the end.

Sorry, got side tracked. Yes this looks ok. Want to submit a proper
patch?