From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754255AbbFJQsK (ORCPT ); Wed, 10 Jun 2015 12:48:10 -0400 Received: from mga09.intel.com ([134.134.136.24]:43426 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754473AbbFJQsC convert rfc822-to-8bit (ORCPT ); Wed, 10 Jun 2015 12:48:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,588,1427785200"; d="scan'208";a="724736079" Date: Wed, 10 Jun 2015 22:19:23 +0530 From: Vinod Koul To: Maxime Ripard Cc: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lior Amsalem , Thomas Petazzoni Subject: Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode Message-ID: <20150610164923.GV28601@localhost> References: <1432645656-20504-1-git-send-email-maxime.ripard@free-electrons.com> <1432645656-20504-4-git-send-email-maxime.ripard@free-electrons.com> <20150608103447.GE28601@localhost> <20150608205351.GC23777@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20150608205351.GC23777@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2015 at 10:53:51PM +0200, Maxime Ripard wrote: > Hi Vinod, > > On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote: > > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote: > > > From: Lior Amsalem > > > > > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of > > > the descriptor and not set through the controller registers. > > > > > > This new feature allows mixing of different commands (even PQ) on the same > > > channel/chain without the need to stop the engine to reconfigure the engine > > > mode. > > > > > > Refactor the driver to be able to use that new feature on the Armada 38x, > > > while keeping the old behaviour on the older SoCs. > > > > > > Signed-off-by: Lior Amsalem > > > Reviewed-by: Ofer Heifetz > > > Signed-off-by: Maxime Ripard > > > --- > > > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +- > > > drivers/dma/mv_xor.c | 82 ++++++++++++++++++++---- > > > drivers/dma/mv_xor.h | 7 ++ > > > 3 files changed, 76 insertions(+), 15 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documentation/devicetree/bindings/dma/mv-xor.txt > > > index 7c6cb7fcecd2..cc29c35266e2 100644 > > > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt > > > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt > > > @@ -1,7 +1,7 @@ > > > * Marvell XOR engines > > > > > > Required properties: > > > -- compatible: Should be "marvell,orion-xor" > > > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor" > > > > marvell,armada-380-xor doesnt seem to exist in binding ? > > I'm not sure what you mean, this patch precisely adds that compatible > to the bindings documentation. Ah my bad, didnt payrequired attention, trusted checkpatch warn. -- ~Vinod