From: Johan Hovold <johan@kernel.org>
To: Claudio Cappelli <claudio.cappelli.linux@gmail.com>
Cc: linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB SERIAL: option.c: add 2020:4000 IDs
Date: Wed, 10 Jun 2015 19:02:02 +0200 [thread overview]
Message-ID: <20150610170202.GD1295@localhost> (raw)
In-Reply-To: <4896608.KHgxjqNgqt@darkstar>
On Wed, Jun 10, 2015 at 06:08:09PM +0200, Claudio Cappelli wrote:
> From: Claudio Cappelli <claudio.cappelli.linux@gmail.com>
>
> Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.
>
> Signed-off-by: Claudio Cappelli <claudio.cappelli.linux@gmail.com>
> Suggested-by: Lars Melin <larsm17@gmail.com>
>
> ---
>
> drivers/usb/serial/option.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
> --- linux/drivers/usb/serial/option.c.orig 2015-06-10 10:42:43.000000000 +0200
> +++ linux/drivers/usb/serial/option.c 2015-06-10 10:53:06.825265579 +0200
> @@ -1765,6 +1765,7 @@ static const struct usb_device_id option
> { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
> { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
> { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
> + { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /* OLICARD300 - MT6225 */
> { USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
> { USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
> { } /* Terminating entry */
You should run checkpatch.pl on your patch before submitting. It would
have let you know that there are some white space issues (leading
spaces). You can ignore the long-line-warning in this case.
Thanks,
Johan
prev parent reply other threads:[~2015-06-10 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:08 [PATCH] USB SERIAL: option.c: add 2020:4000 IDs Claudio Cappelli
2015-06-10 17:02 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610170202.GD1295@localhost \
--to=johan@kernel.org \
--cc=claudio.cappelli.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox